[PATCH v2 6/7] gdi32: Store unix file name on font faces.

[Rémi Bernon]

On 2020-09-17 17:50, Alexandre Julliard wrote:
> Rémi Bernon <rbernon at codeweavers.com> writes:
> 
>> So we can then more easily invert the creation order between faces and
>> ft_face, and eventually use FreeType cache with Face* as FTC_FaceID.
> 
> I'm not sure this is going in the right direction either, particularly
> with the view of moving to PE. I would think we'd want to keep as much
> as possible of the GDI internal structures independent of the backend,
> and not need to be aware of things like Unix paths.
> 

Well, it's not strictly required to be unix paths for FreeType 
integration, especially if we think about having a PE freetype as some 
point (where it would use NT paths directly).

What the Face needs to store is the path that will be then used by 
FreeType, in order to save conversions.

Now, there's a potential issue on Face creation, as I was intending to 
open and mmap the font files directly. As create_face was already 
calling stat, it seemed like a good place to do this too.

If the idea is to completely get rid of unix paths somehow, and use 
Win32 file access instead, then the quick test I did lately tells me 
that it has an overhead that makes the whole optimization a bit useless.
-- 
Rémi Bernon <rbernon at codeweavers.com>