[PATCH v2 3/5] server: Introduce IOCTL_AFD_CREATE.

[Alexandre Julliard]

Zebediah Figura <zfigura at codeweavers.com> writes:

> On 9/18/20 4:31 AM, Alexandre Julliard wrote:
>> Zebediah Figura <z.figura12 at gmail.com> writes:
>> 
>>> +#include <winioctl.h>
>>> +
>>> +#define IOCTL_AFD_CREATE                    CTL_CODE(FILE_DEVICE_NETWORK,   0, METHOD_BUFFERED, FILE_WRITE_ACCESS)
>>> +
>>> +struct afd_create_params
>>> +{
>>> +    int family, type, protocol;
>>> +    unsigned int flags;
>>> +};
>> 
>> Do we really need yet another set of Wine-specific ioctls?
>
> I assumed that at least it'd be preferable to a set of Wine-specific
> server calls; is this not the case? In particular it lets us use the
> ntdll infrastructure for asynchronous I/O, instead of half-duplicating
> it in ws2_32. I don't know what would be better here.

Sure, moving things to ntdll is still an improvement.

> Unless the proposal is to use native ioctls, but I couldn't easily find
> them and I don't know how to safely reverse-engineer them.

Yes, I was hoping that there would be a more compatible way of doing
that. But if it's all undocumented, maybe that's the best we can do for
now...

-- 
Alexandre Julliard
julliard at winehq.org