[PATCH 2/2 resend] oleaut32: Fix rewriting FUNCDESC to FUNC_DISPATCH.

[Huw Davies]

On Mon, Sep 21, 2020 at 01:49:32PM +0000, Puetz Kevin A wrote:
> > > > On Monday, Sep 20, 2020 at 5:55 AM, Huw Davies wrote:
> > > >
> > > On Fri, Sep 18, 2020 at 09:38:24PM -0500, Kevin Puetz wrote:
> > >
> > > There are several things changing in this patch, please could you
> > > split them up?  In addition to making the patch easier to review and
> > > easier to fix regressions, splitting the patch will enable more
> > > meaningful commit subject lines to be written.
> > 
> > Can do. I was trying to avoid a patch that made changes that were not yet
> > tested, and all the fixes were needed to pass a round-trip comparison
> > of dispinterface derived-from dual interface.
> > 
> > Would you prefer a series of (separate) fixes, followed by the conformance
> > test,
> > Or a conformance test (with todo_wine) followed by fixes gradually
> > removing the todo_wine?
> 
> Actually, NAK that, todo_wine won't really work since I'm adding additional
> test *data* (in test_tlb.idl) that exposes existing bugs, but the code doing the
> ok() calls is mostly not new. So there's no easy way to todo_wine the failures,
> the test data just has to be added last to un-squash this commit without
> showing broken tests in the middle of the series.

Ideally, tests with todos, followed by a series of fixes that remove the todos.
If that's not possible, then a series of fixes followed by the tests.

Huw.