[PATCH v2 4/6] oleaut32: omit [lcid] parameter when rewriting FUNCDESC to FUNC_DISPATCH.

Kevin Puetz PuetzKevinA at JohnDeere.com
Mon Sep 21 09:17:20 CDT 2020


[lcid] parameters are supplied from IDispatch::Invoke's parameters,
rather than via DISPPARAMS::rgvargs[] and should also be removed
from the FUNC_DISPATCH translation.

Signed-off-by: Kevin Puetz <PuetzKevinA at JohnDeere.com>
---
 dlls/oleaut32/typelib.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c
index 2c9b4ac5eb..13ccb6041a 100644
--- a/dlls/oleaut32/typelib.c
+++ b/dlls/oleaut32/typelib.c
@@ -5890,6 +5890,14 @@ static HRESULT TLB_AllocAndInitFuncDesc( const FUNCDESC *src, FUNCDESC **dest_pt
              * So the function signature should show no return value. */
             dest->elemdescFunc.tdesc.vt = VT_VOID;
 
+        /* The now-last (except [retval], removed above) parameter might be labeled [lcid].
+         * If so it will be supplied from Invoke(lcid), so also not via DISPPARAMS::rgvarg */
+        if (dest->cParams &&
+            (dest->lprgelemdescParam[dest->cParams - 1].u.paramdesc.wParamFlags & PARAMFLAG_FLCID))
+        {
+            /* remove the last parameter */
+            dest->cParams--;
+        }
     }
 
     *dest_ptr = dest;



More information about the wine-devel mailing list