[PATCH 4/4] wined3d: Fully move the depth buffer enable state to wined3d_depth_stencil_state.

Zebediah Figura zfigura at codeweavers.com
Thu Sep 24 10:51:58 CDT 2020



On 9/24/20 6:13 AM, Henri Verbeet wrote:
> On Thu, 24 Sep 2020 at 08:23, Zebediah Figura <z.figura12 at gmail.com> wrote:
>> @@ -100,16 +100,15 @@ static const struct wined3d_state_entry_template misc_state_template_vk[] =
>>      {STATE_INDEXBUFFER,                                   {STATE_INDEXBUFFER,                                   state_nop}},
>>      {STATE_RENDER(WINED3D_RS_ANTIALIAS),                  {STATE_RENDER(WINED3D_RS_ANTIALIAS),                  state_nop}},
>>      {STATE_RENDER(WINED3D_RS_TEXTUREPERSPECTIVE),         {STATE_RENDER(WINED3D_RS_TEXTUREPERSPECTIVE),         state_nop}},
>> -    {STATE_RENDER(WINED3D_RS_ZENABLE),                    {STATE_RENDER(WINED3D_RS_ZENABLE),                    state_nop}},
>>      {STATE_RENDER(WINED3D_RS_WRAPU),                      {STATE_RENDER(WINED3D_RS_WRAPU),                      state_nop}},
>>      {STATE_RENDER(WINED3D_RS_WRAPV),                      {STATE_RENDER(WINED3D_RS_WRAPV),                      state_nop}},
>>      {STATE_RENDER(WINED3D_RS_LINEPATTERN),                {STATE_RENDER(WINED3D_RS_LINEPATTERN),                state_nop}},
>>      {STATE_RENDER(WINED3D_RS_MONOENABLE),                 {STATE_RENDER(WINED3D_RS_MONOENABLE),                 state_nop}},
>>      {STATE_RENDER(WINED3D_RS_ROP2),                       {STATE_RENDER(WINED3D_RS_ROP2),                       state_nop}},
>>      {STATE_RENDER(WINED3D_RS_PLANEMASK),                  {STATE_RENDER(WINED3D_RS_PLANEMASK),                  state_nop}},
>> -    {STATE_RENDER(WINED3D_RS_ZWRITEENABLE),               {STATE_RENDER(WINED3D_RS_ZENABLE)}},
>> +    {STATE_RENDER(WINED3D_RS_ZWRITEENABLE),               {STATE_RENDER(WINED3D_RS_ZWRITEENABLE)}},
> I did not verify this, but I think this would fail
> validate_state_table() because STATE_RENDER(WINED3D_RS_ZWRITEENABLE)
> lacks a handler.
> 

I even noticed that error in a later patch, but forgot to actually fix
it :-/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200924/7c9284a9/attachment.sig>


More information about the wine-devel mailing list