[PATCH v4 3/3] winegstreamer: Implement IMFMediaStream::GetStreamDescriptor.

[Zebediah Figura]

On 9/24/20 6:48 PM, Derek Lesho wrote:
> On 9/24/20 6:42 PM, Zebediah Figura wrote:
> 
>>
>> On 9/24/20 3:56 PM, Derek Lesho wrote:
>>> On 9/24/20 12:27 PM, Zebediah Figura wrote:
>>>>>        enum
>>>>>        {
>>>>>            STREAM_STUB,
>>>>> +        STREAM_INACTIVE,
>>>> What's the difference between these two states? There doesn't seem to be
>>>> a difference in this patch.
>>> I think it's just a vestige of a prior version of the patchset, I'll
>>> merge STREAM_STUB into STREAM_INACTIVE.
>> Are there other members of this enumeration that will be introduced, or
>> can it become a simple boolean flag?
> There's one more state I have in future patches, STREAM_RUNNING. [1]  I 
> presume STREAM_PAUSED will also be necessary once pausing support is 
> added.  I am open to turning these into simple boolean flags if you 
> think that's better.

I don't have a strong opinion on it. Given that there's a distinction
between running/paused/stopped that doesn't translate nicely to boolean
flags, I guess it's probably clearest to leave it as an enumeration.

> 
> 1: 
> https://github.com/Guy1524/wine/blob/mfplat_cleanup/dlls/winegstreamer/media_source.c#L60
> 
> 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200924/37bbd3f5/attachment.sig>