[PATCH v3] ole32: Check for NULL parameter in ReleaseStgMedium().

Huw Davies huw at codeweavers.com
Mon Sep 28 03:31:11 CDT 2020


From: Chao Long <longchao at uniontech.com>

libcef can call ReleaseStgMedium( NULL )

Signed-off-by: Chao Long <longchao at uniontech.com>
Signed-off-by: Huw Davies <huw at codeweavers.com>
---
 dlls/ole32/ole2.c       | 2 ++
 dlls/ole32/tests/ole2.c | 6 ++++++
 2 files changed, 8 insertions(+)

diff --git a/dlls/ole32/ole2.c b/dlls/ole32/ole2.c
index 15c4f8234f3..4464ba07144 100644
--- a/dlls/ole32/ole2.c
+++ b/dlls/ole32/ole2.c
@@ -2023,6 +2023,8 @@ found:
 void WINAPI ReleaseStgMedium(
   STGMEDIUM* pmedium)
 {
+  if (!pmedium) return;
+
   switch (pmedium->tymed)
   {
     case TYMED_HGLOBAL:
diff --git a/dlls/ole32/tests/ole2.c b/dlls/ole32/tests/ole2.c
index cd7eb839233..42e377f8a63 100644
--- a/dlls/ole32/tests/ole2.c
+++ b/dlls/ole32/tests/ole2.c
@@ -4610,6 +4610,11 @@ static void test_OleCreateStaticFromData(void)
     IStorage_Release(storage);
 }
 
+static void test_ReleaseStgMedium( void )
+{
+    ReleaseStgMedium( NULL );
+}
+
 START_TEST(ole2)
 {
     DWORD dwRegister;
@@ -4661,6 +4666,7 @@ START_TEST(ole2)
     test_data_cache_save_data();
     test_data_cache_contents();
     test_OleCreateStaticFromData();
+    test_ReleaseStgMedium();
 
     CoUninitialize();
 }
-- 
2.23.0




More information about the wine-devel mailing list