[PATCH] dxgi/tests: Check that the last adapter is always WARP.

Rémi Bernon rbernon at codeweavers.com
Wed Sep 30 04:46:45 CDT 2020


On 9/30/20 11:39 AM, Zhiyi Zhang wrote:
> Hi Rémi,
> 
> I sent a v2 with some minor changes.

I saw that, thanks!

> 
> I have some questions. WARP is only always present on Win8+[1], if the game depends on the case,
> what will happen on win7? I checked a Win7 machine and there is no WARP adapter in DXGI.
> 

Well, no idea actually. I believe they may print a warning in that case, 
I saw that only with Mafia III DE launcher, which is quite recent and 
probably doesn't care about old Windows versions. Also most likely the 
case where there's a single adapter means there's only an integrated 
GPU, which will probably trigger a warning anyway.

> My multi-GPU work mostly contains changes to wined3d code. I think only DXGI reports such an extra
> WARP adapter when a hardware GPU is present. So if you want to add a WARP adapter in DXGI, there
> should be no conflicts.
> 

Alright, I was actually trying to add it to the wined3d adapter list, as 
it was easier that way, but I don't know exactly what adding it there 
implies. Maybe it should indeed only be reported by DXGI, so I'll see if 
we can safely report a dummy adapter here.

> Thanks,
> Zhiyi
> 
> [1]: https://docs.microsoft.com/en-us/windows/win32/direct3ddxgi/d3d10-graphics-programming-guide-dxgi#new-info-about-enumerating-adapters-for-windows-8
> 
-- 
Rémi Bernon <rbernon at codeweavers.com>



More information about the wine-devel mailing list