[PATCH 1/3] mfuuid: Add mfplay GUIDs.

[Nikolay Sivov]

On 4/1/21 10:11 PM, Zebediah Figura (she/her) wrote:
> On 4/1/21 2:09 PM, Nikolay Sivov wrote:
>>
>>
>> On 4/1/21 9:51 PM, Zebediah Figura (she/her) wrote:
>>> On 4/1/21 1:46 PM, Nikolay Sivov wrote:
>>>> Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
>>>> ---
>>>>    dlls/mfuuid/mfuuid.c | 5 +++++
>>>>    1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/dlls/mfuuid/mfuuid.c b/dlls/mfuuid/mfuuid.c
>>>> index 537eaef6427..ae649cce633 100644
>>>> --- a/dlls/mfuuid/mfuuid.c
>>>> +++ b/dlls/mfuuid/mfuuid.c
>>>> @@ -35,3 +35,8 @@
>>>>      DEFINE_GUID(MF_SCRUBBING_SERVICE,
>>>> 0xdd0ac3d8,0x40e3,0x4128,0xac,0x48,0xc0,0xad,0xd0,0x67,0xb7,0x14);
>>>>    DEFINE_GUID(CLSID_FileSchemePlugin,
>>>> 0x477ec299,0x1421,0x4bdd,0x97,0x1f,0x7c,0xcb,0x93,0x3f,0x21,0xad);
>>>> +
>>>> +/* mfplay.h is not used here because of the other header it
>>>> includes, particularly evr.idl */
>>>> +DEFINE_GUID(IID_IMFPMediaPlayer,
>>>> 0xa714590a,0x58af,0x430a,0x85,0xbf,0x44,0xf5,0xec,0x83,0x8d,0x85);
>>>> +DEFINE_GUID(IID_IMFPMediaPlayerCallback,
>>>> 0x766c8ffb,0x5fdb,0x4fea,0xa2,0x8d,0xb9,0x12,0x99,0x6f,0x51,0xbd);
>>>> +DEFINE_GUID(IID_IMFPMediaItem,
>>>> 0x90eb3e6b,0xecbf,0x45cc,0xb1,0xda,0xc6,0xfe,0x3e,0xa7,0x0d,0x57);
>>>>
>>>
>>> Is it not possible to include evr.h before initguid.h?
>>>
>> If you mean to include it in mfuuid.c before initguid.h, no, that
>> doesn't work, because evr.idl itself imports mfidl.idl. That would be an
>> equivalent of removing mfidl.h that goes after initguid.h.
>>
>
> Sure, makes sense. I guess you could use a separate file, along the
> lines of dlls/uuid/d2d.c, but that's probably overkill here.
>
No, I like that, will resend.