[PATCH v2 3/3] conhost: Fix delayed wrapping around when ENABLE_VIRTUAL_TERMINAL_PROCESSING is set.

[Gabriel Ivăncescu]

On 02/04/2021 16:11, Jacek Caban wrote:
> On 4/2/21 3:06 PM, Gabriel Ivăncescu wrote:
>> I feel like I'll have to add a hack to do this and I don't like it. 
>> For example, check for delayed newline and len == 1 and then decrement 
>> tty_cursor_x *before* tty_sync is called, so it doesn't put the \b. (I 
>> don't know if len == 1 is a good condition, if I have to add this hack 
>> I'll probably test it some more)
> 
> Unless I'm missing something, if you leave cursor_x == width, then tty 
> cursor will be already in sync so there will be no reason to add '\b's.
> 
> Jacek

Yeah, but what about when we write "ab" (two chars at once) and Windows 
does insert a \b in that case? I'm not sure yet, I'll see what happens, 
but I can't promise it won't have some semi-hacks if it's really needed.