[PATCH v4 3/3] conhost: Fix delayed wrapping around when ENABLE_VIRTUAL_TERMINAL_PROCESSING is set.
Gabriel Ivăncescu
gabrielopcode at gmail.com
Sat Apr 3 08:14:15 CDT 2021
On 03/04/2021 00:29, Jacek Caban wrote:
> Hi Gabriel,
>
> On 4/2/21 7:07 PM, Gabriel Ivăncescu wrote:
>> Remember the fact we completed the entire line but normalize the cursor
>> otherwise. A newline is delayed so it wraps when writing a new character
>> if the cursor is outside the width.
>>
>> This can happen in practice when writing one character at a time to the
>> console; right now it will keep overwriting the last character on the
>> line.
>
> I experimented a bit with your patches and think that we can just emit
> fewer '\b's. What do you think about something like the attached version?
>
> Thanks,
> Jacek
Thanks, I don't have particularly strong opinions on such an edge case,
as long as you're fine with it.
I resent new version with some typo fixes while at it, and silenced a
`value computed is not used` warning in the tests.
More information about the wine-devel
mailing list