[tools] testbot/PatchUtils: Document the make_* scripts indirect impacts.
Francois Gouget
fgouget at codeweavers.com
Tue Apr 6 04:24:26 CDT 2021
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
testbot/lib/WineTestBot/PatchUtils.pm | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/testbot/lib/WineTestBot/PatchUtils.pm b/testbot/lib/WineTestBot/PatchUtils.pm
index 0d60fdb29..b33ad9bd1 100644
--- a/testbot/lib/WineTestBot/PatchUtils.pm
+++ b/testbot/lib/WineTestBot/PatchUtils.pm
@@ -443,6 +443,8 @@ sub GetPatchImpacts($)
$Path = $1;
$Impacts->{BuildRoot} = $Impacts->{MakeRequests} = 1;
$Impacts->{PatchedRoot} = $Impacts->{IsWinePatch} = 1;
+ # Note that make_requests essentially impacts every test but these
+ # indirect impacts are ignored (use test=all if it really matters).
}
elsif ($Line =~ m=^--- \w+/(dlls/dsound/make_fir)$=)
{
@@ -461,18 +463,30 @@ sub GetPatchImpacts($)
$Path = $1;
$Impacts->{BuildRoot} = $Impacts->{MakeOpenGL} = 1;
$Impacts->{PatchedRoot} = $Impacts->{IsWinePatch} = 1;
+ # Note that make_opengl impacts other dlls through header changes so
+ # it could make sense for the TestBot to rerun the corresponding tests
+ # when test=module. But that would require either hardcoding the list
+ # of impacted modules, or detecting changed source files (and thus the
+ # list of tests to run) at build time which is incompatible with the
+ # current architecture.
+ # So these indirect impacts are ignored for now. A workaround is to
+ # use test=all.
}
elsif ($Line =~ m=^--- \w+/(dlls/winevulkan/make_vulkan)$=)
{
$Path = $1;
$Impacts->{BuildRoot} = $Impacts->{MakeVulkan} = 1;
$Impacts->{PatchedRoot} = $Impacts->{IsWinePatch} = 1;
+ # Note that make_vulkan impacts other dlls through header changes.
+ # See the make_opengl comment.
}
elsif ($Line =~ m=^--- \w+/(tools/make_unicode)$=)
{
$Path = $1;
$Impacts->{BuildRoot} = $Impacts->{MakeUnicode} = 1;
$Impacts->{PatchedRoot} = $Impacts->{IsWinePatch} = 1;
+ # Note that make_unicode changes the source for many dlls.
+ # See the make_opengl comment.
}
elsif ($Line =~ m=^--- /dev/null$=)
{
--
2.20.1
More information about the wine-devel
mailing list