[tools] testbot/PatchUtils: Rerun the tests when the Makefile is modified.

Francois Gouget fgouget at codeweavers.com
Wed Apr 7 04:05:50 CDT 2021


Makefile changes are less likely to cause tests to fail but they are
also quite rare so they are not worth special-casing.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
It also means that adding a new test unit causes all of that module's 
test units to be rerun. But that's not very frequent either.
---
 testbot/lib/WineTestBot/PatchUtils.pm | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/testbot/lib/WineTestBot/PatchUtils.pm b/testbot/lib/WineTestBot/PatchUtils.pm
index a7d33f685..eb9fa09bb 100644
--- a/testbot/lib/WineTestBot/PatchUtils.pm
+++ b/testbot/lib/WineTestBot/PatchUtils.pm
@@ -570,9 +570,6 @@ sub GetPatchImpacts($)
     my $TestFiles = $Module->{TestFiles};
     foreach my $File (sort keys %$TestFiles)
     {
-      # Assume makefile modifications may break the build but not the tests
-      next if ($File eq "Makefile.in");
-
       my $Base = $File;
       if ($Base !~ s/(?:\.c|\.spec)$//)
       {
-- 
2.20.1




More information about the wine-devel mailing list