[PATCH 5/5] ntoskrnl/tests: Use a more descriptive name for the netio test driver.

Paul Gofman pgofman at codeweavers.com
Wed Apr 7 04:34:23 CDT 2021


On 4/7/21 06:41, Zebediah Figura (she/her) wrote:
> On 4/5/21 4:10 AM, Paul Gofman wrote:
>> FWIW the idea was not to have this test driver specific to netio but
>> rather for the tests which require Windows 7+ to load (or test the
>> functionality present on newer Windows only to avoid extra checks for
>> keeping compatibility with earlier versions).
>>
>
> I guess the patch has already been committed, but I'd offer as a weak
> counterpoint that it probably makes sense to separate netio tests
> semantically from others. Or, if not, that this test unit can be
> renamed again ("driver_win7"?) if it ever becomes useful to add other
> tests here. I don't feel particularly strongly though.
>
Do you see any reason why netio deserves a separate driver module? E.
g., if we come to adding WdfLdr, why not to link it and put the tests to
the same test driver? Anyway, now there are netio tests only, that can
probably be thought of once anyone decides to add some new Win7+
specific tests.




More information about the wine-devel mailing list