[PATCH v2 3/3] gdi32: Use a global cache for frequently used color tables for RGB value lookups.

Huw Davies huw at codeweavers.com
Thu Apr 8 02:31:05 CDT 2021


On Wed, Apr 07, 2021 at 04:34:15PM +0300, Gabriel Ivăncescu wrote:
> On 07/04/2021 12:03, Huw Davies wrote:
> > Yeah, I'm not convinced, not even close.  You're going to have to
> > provide some pretty good evidence, with real world apps, that this is
> > necessary over a local, lazy-init solution.
> 
> Well a simple real world test is in the bug report with Winamp's Credits,
> while it's not that important, it's easy enough to test compared to, say,
> games.
> 
> When I tested on Windows it does seem to cache color tables between calls
> because it was just way too fast, unless they have some voodoo algorithm to
> generate the color table extremely quickly on each call.

A possible algorithm[1] has been suggested (twice).  To make progress here it
would be a good idea to try that.

Huw.
[1] a local lazy-init.



More information about the wine-devel mailing list