[tools] winetest/gather: Avoid a variable name collision for the header rows.

Francois Gouget fgouget at codeweavers.com
Thu Apr 8 05:23:22 CDT 2021


Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
Two $title variables with different scopes were intertwined!
I renamed $stats to $stats_row just for consistency.
---
 winetest/gather | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/winetest/gather b/winetest/gather
index 4cbf8e67e..302def437 100755
--- a/winetest/gather
+++ b/winetest/gather
@@ -504,7 +504,7 @@ sub build_header_footer($)
     my ($reports)=@_;
 
     my $unit_count=scalar(keys %alltests);
-    my ($title, $stats);
+    my ($title_row, $stats_row);
     foreach my $rep (@{$reports}) {
         my $report=$rep;
         my $msg;
@@ -528,7 +528,7 @@ sub build_header_footer($)
 EOF
             chop $msg;
         }
-        $title .=  <<"EOF";
+        $title_row .=  <<"EOF";
       <th class="sticky">
 $msg
       </th>
@@ -549,31 +549,31 @@ EOF
         my $title = "$unit_count unit tests, $report->{errors} have errors";
         $title .= ", $report->{todos} have todos" if $report->{todos};
 
-        $stats .= "      <th class=\"result $class\"><a title=\"$title\">$count<br>$prcnt\%</a></th>\n";
+        $stats_row .= "      <th class=\"result $class\"><a title=\"$title\">$count<br>$prcnt\%</a></th>\n";
     }
-    chop $title;
-    chop $stats;
+    chop $title_row;
+    chop $stats_row;
     return <<"EOF";
   <thead>
     <tr>
       <th class="test sticky" colspan="2">platforms</th>
-$title
+$title_row
     </tr>
     <tr>
       <th class="test" colspan="2">errors</th>
-$stats
+$stats_row
       <th class="test"></th>
     </tr>
   </thead>
   <tfoot>
     <tr>
       <th class="test" colspan="2">errors</th>
-$stats
+$stats_row
       <th class="test"></th>
     </tr>
     <tr>
       <th class="test" colspan="2">platforms</th>
-$title
+$title_row
     </tr>
   </tfoot>
 EOF
-- 
2.20.1




More information about the wine-devel mailing list