[PATCH 1/5] user32/tests: Add more SendInput tests.

Rémi Bernon rbernon at codeweavers.com
Thu Apr 8 12:49:16 CDT 2021


On 4/8/21 7:01 PM, Alexandre Julliard wrote:
> Rémi Bernon <rbernon at codeweavers.com> writes:
> 
>> +#ifdef _WIN64
>> +    todo_wine
>> +    ok( res == 0 && GetLastError() == ERROR_CALL_NOT_IMPLEMENTED, "SendInput returned %u, error %#x\n", res, GetLastError() );
>> +#else
>> +    ok( res == 16 && GetLastError() == 0xdeadbeef, "SendInput returned %u, error %#x\n", res, GetLastError() );
>> +#endif
> 
> I doubt that there's anything 64-bit specific about this. Most likely
> that's another case of imperfect WoW64 translation that wouldn't appear
> on pure 32-bit. I don't think we want to add #ifdefs for this.
> 

I don't mind re-sending with the 32bit tests marked as broken, but it 
seemed to me that there was a difference. As I understand it this is 
some legacy thing and I guess that was cleaned up at some point to 
return genuine error codes indicating that it does nothing now.

For instance, the 32bit tests running on winxp here:

   https://testbot.winehq.org/JobDetails.pl?Key=88479

-- 
Rémi Bernon <rbernon at codeweavers.com>



More information about the wine-devel mailing list