[PATCH 3/3] mf: Shutdown the media sink on topology shutdown.

Rémi Bernon rbernon at codeweavers.com
Mon Apr 12 11:36:04 CDT 2021


ShutdownObject doesn't alway call Shutdown on the activated object, for
instance sample grabbers, and we are then leaking some resources.

Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
---
 dlls/mf/session.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/mf/session.c b/dlls/mf/session.c
index 20ccdd0535e..bcf8ad5ba71 100644
--- a/dlls/mf/session.c
+++ b/dlls/mf/session.c
@@ -838,7 +838,7 @@ static void session_shutdown_current_topology(struct media_session *session)
                         WARN("Failed to shut down activation object for the sink, hr %#x.\n", hr);
                     IMFActivate_Release(activate);
                 }
-                else if (SUCCEEDED(topology_node_get_object(node, &IID_IMFStreamSink, (void **)&stream_sink)))
+                if (SUCCEEDED(topology_node_get_object(node, &IID_IMFStreamSink, (void **)&stream_sink)))
                 {
                     if (SUCCEEDED(IMFStreamSink_GetMediaSink(stream_sink, &sink)))
                     {
-- 
2.31.0




More information about the wine-devel mailing list