[PATCH 6/7] mfplay: Fix a leak on error path in synchronous CreateMediaItemFromURL() (Coverity).

Nikolay Sivov nsivov at codeweavers.com
Tue Apr 13 01:03:33 CDT 2021


Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
---
 dlls/mfplay/player.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/dlls/mfplay/player.c b/dlls/mfplay/player.c
index e061e21acb8..a95e1d3ca36 100644
--- a/dlls/mfplay/player.c
+++ b/dlls/mfplay/player.c
@@ -835,7 +835,12 @@ static HRESULT media_player_create_item_from_url(struct media_player *player,
         }
 
         if (SUCCEEDED(hr))
+        {
             *ret = &item->IMFPMediaItem_iface;
+            IMFPMediaItem_AddRef(*ret);
+        }
+
+        IMFPMediaItem_Release(&item->IMFPMediaItem_iface);
 
         return hr;
     }
-- 
2.30.2




More information about the wine-devel mailing list