[PATCH 1/2] cmd: Use terminated strings in WCMD_ReadAndParseLine()

Hugh McMaster hugh.mcmaster at outlook.com
Tue Apr 13 07:33:17 CDT 2021


On Mon, 12 Apr 2021 at 18:04, Gijs Vermeulen wrote:
>
> Op ma 12 apr. 2021 om 08:17 schreef Hugh McMaster:
>>
>> This is very unusual. Why not just use lstrlenW(...)?
>
>
> I just followed these examples[1][2], but I can change it if necessary.

Thanks. It's just adding unnecessary complexity in this case.

>> You should also look at calculating the string length within
>> WCMD_keyword_ws_found(), instead of passing the length as an argument.
>> But do this as a separate patch.
>
>
> Will do.
>
> [1] https://source.winehq.org/git/wine.git/commit/76ee089aade14ddf833c4ef7c382c8d413664251
> [2] https://source.winehq.org/git/wine.git/commit/762f51cf93b6efca0defb2929f3278abb034dae7



More information about the wine-devel mailing list