[PATCH vkd3d 5/6] vkd3d-shader: Write the SM1 constant table.

Henri Verbeet hverbeet at gmail.com
Fri Apr 16 09:13:24 CDT 2021


On Fri, 16 Apr 2021 at 01:40, Zebediah Figura (she/her)
<zfigura at codeweavers.com> wrote:
> On 4/14/21 7:57 AM, Henri Verbeet wrote:
> > On Wed, 14 Apr 2021 at 07:03, Zebediah Figura <zfigura at codeweavers.com>
> wrote:
> >> diff --git a/include/vkd3d_d3dx9shader.h b/include/vkd3d_d3dx9shader.h
> >> new file mode 100644
> >> index 00000000..ba69efbd
> >> --- /dev/null
> >> +++ b/include/vkd3d_d3dx9shader.h
> > Should this be an IDL file? I'm not sure how much of d3dx9shader.h we
> > intend to provide, but it does have COM interfaces like
> > ID3DXConstantTable.
>
> I guess it depends if we want ID3DXConstantTable in vkd3d, which isn't
> clear to me, but either way it seems quite easy to make it an IDL.
>
I could probably come up with arguments for either option, but if
we're not going to provide ID3DXConstantTable, and by extension
D3DXCompileShader() and variants, is there much of a point in
providing vkd3d_d3dx9shader.h as a public header?



More information about the wine-devel mailing list