[tools] winetest/dissect: Fix handling of skipped test unit.
Francois Gouget
fgouget at codeweavers.com
Tue Apr 20 09:50:09 CDT 2021
close_test_unit() adds an entry in summary.txt for every test unit.
So the report parser must set $summary instead of manually adding a
redundant summary.txt entry.
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
This caused skipped tests to appear as '0 failures' in the index pages
instead of 'skipped'. That's because close_test_unit() was adding an
extra 'not-skipped' entry in summary.txt.
---
winetest/dissect | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/winetest/dissect b/winetest/dissect
index c58e47f57..ce3329ea6 100755
--- a/winetest/dissect
+++ b/winetest/dissect
@@ -627,7 +627,7 @@ while ($line = <IN>) {
if ($l_type eq "skipped")
{
add_test_line("skipped", "Skipped by user request");
- print SUM "- $dll $unit skipped - - - $source\n";
+ $summary = "skipped - - -";
mydie "too many test units skipped by user request (>$maxuserskips at $dll:$unit)" if ++$skipped_units > $maxuserskips;
$rc = 0;
}
--
2.20.1
More information about the wine-devel
mailing list