[PATCH] winetest: Trace skipped dlls when in exclude (-n) mode.

Francois Gouget fgouget at codeweavers.com
Wed Apr 21 02:32:37 CDT 2021


When the command line specifies the list of tests to run, tracing all
the skipped dlls unnecessarily spams the test output.
But when the command line contains the list of (at most 64) excluded
dlls, tracing them ensures tools analysing the report know why the
corresponding dlls were skipped.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
The TestBot specifies the list of tests to run on the WineTest command
line which is why a previous commit removed this trace (9b1431459d30).
But it was unnecessarily broad.
This version of the patch does not interfere with the TestBot and 
ensures test.winehq.org can report the right status for skipped dlls.
---
 programs/winetest/main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/programs/winetest/main.c b/programs/winetest/main.c
index 107151c927f..cb2f23a161e 100644
--- a/programs/winetest/main.c
+++ b/programs/winetest/main.c
@@ -918,6 +918,7 @@ extract_test_proc (HMODULE hModule, LPCSTR lpszType, LPSTR lpszName, LONG_PTR lP
     if (test_filtered_out( lpszName, NULL ))
     {
         nr_of_skips++;
+        if (exclude_tests) xprintf ("    %s=skipped\n", dllname);
         return TRUE;
     }
     extract_test (&wine_tests[nr_of_files], tempdir, lpszName);
-- 
2.20.1



More information about the wine-devel mailing list