[PATCH 1/2] ntdll/tests: Refactor RtlSetEnvironmentVariable() tests.

Alexandre Julliard julliard at winehq.org
Wed Apr 21 15:46:55 CDT 2021


Dmitry Timoshkov <dmitry at baikal.ru> writes:

> I hope that I asked nicely enough, and didn't ask that much, I wouldn't
> call this as a demand. I think that it doesn't count as an extra work
> simply keeping existing API pointers.

It's still extra work and extra code, so there needs to be some benefit
to doing it. Of course keeping the existing pointers isn't much work,
but it doesn't do any good unless new code also uses pointers
everywhere. Clearly that's not the case.

It used to be necessary to do this since there was no ntdll import lib,
but it's been available in the PSDK for about 10 years now, so honestly
I don't see the point anymore.

If you absolutely need to use such an old PSDK, is there a good reason
you can't simply copy an ntdll import lib into it once and for all?

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list