[PATCH v2 4/4] user32: Move (Un)LoadKeyboardLayoutW from winex11.drv to user32.

[Dmitry Timoshkov]

Rémi Bernon <rbernon at codeweavers.com> wrote:

> Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
> ---
>  dlls/user32/driver.c              | 26 ---------------
>  dlls/user32/input.c               | 53 ++++++++++++++++++++++++++-----
>  dlls/user32/user_private.h        |  2 --
>  dlls/winex11.drv/keyboard.c       | 21 ------------
>  dlls/winex11.drv/winex11.drv.spec |  2 --
>  5 files changed, 45 insertions(+), 59 deletions(-)

This patch is going in the wrong direction IMO, it won't allow implementing
proper support for keyboard layouts and WM_INPUTLANGCHANGE using XKB keyboard
groups. I sent a patch that implements ActivateKeyboardLayout() using XKB
extension, and top of it WM_INPUTLANGCHANGE could be added:
https://www.winehq.org/pipermail/wine-devel/2020-April/164161.html
Unfortunately it was ignored.

How are you planning to implement support for keyboard layouts without
support on the driver side?

-- 
Dmitry.