[PATCH v7 4/4] ntdll: Allow renaming a file/directory to a different casing of itself.

Huw Davies huw at codeweavers.com
Mon Apr 26 09:23:01 CDT 2021


On Mon, Apr 26, 2021 at 04:03:50PM +0200, Rémi Bernon wrote:
> On 4/23/21 5:52 PM, Gabriel Ivăncescu wrote:
> > +/***********************************************************************
> > + *           nt_to_unix_file_name_with_casing
> > + *
> > + * Same as nt_to_unix_file_name, but additionally return unix file name
> > + * without path, with the original casing from the NT file name.

Another nit-pick.  "casing" is the process of changing a character's case, the
correct term here is "original case".  Llikewise the function name, param names,
and variables should be changed to reflect that.

> > + */
> > +static NTSTATUS nt_to_unix_file_name_with_casing( const OBJECT_ATTRIBUTES *attr, char **name_ret,
> > +                                                  char **casing_ret, UINT disposition )
> > +{
> > +    int len = attr->ObjectName->Length / sizeof(WCHAR);
> > +    const WCHAR *nt_filename;
> > +    NTSTATUS status;
> > +    char *casing;
> > +

Huw.



More information about the wine-devel mailing list