[PATCH v2 1/3] user32: Move ToUnicodeEx from wineandroid.drv to user32.

Alexandre Julliard julliard at winehq.org
Tue Apr 27 09:26:08 CDT 2021


Rémi Bernon <rbernon at codeweavers.com> writes:

> In the end, having the default implementation run all the time didn't
> seem too bad, especially if as it's not doing much, and if we consider 
> it could then be extended to cover more cases and reduce the amount of
> driver code.
>
> If we consider keyboard layouts I would think that it could be decided
> based on the HKL, with some special value(s) meaning the layout is 
> handled by the driver while "standard" layout would be implemented in
> user32.
> 
> Anyway, If you like the NTSTATUS style more, I can do it like this.

I still find it better to call the driver first, and do the extra work
only if needed. If we do it right, the default implementation is only
going to become more complex, and that would be all the more reason to
ask the driver first.

I'm not sure that I see a need to use NTSTATUS here, plus it wouldn't
quite fit with the usual user32 calling conventions. At some point we
may want to turn this into a syscall interface and use NTSTATUS
everywhere, but that would be a complete redesign of the driver
interface.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list