[PATCH] winex11.drv: Handle Vulkan surface creation with NULL hwnd.

Paul Gofman pgofman at codeweavers.com
Fri Apr 30 09:18:49 CDT 2021


On 4/30/21 17:13, Rémi Bernon wrote:
>
> Maybe we could just use the dummy parent window as a backing window
> instead of creating a new one, returning it from create_client_window
> when hwnd parameter is NULL?

We are using vkCreateXlibSurfaceKHR() with this window. Reusing the same
X window for that looks like undefined behaviour and overall rather
fragile to me.


> I also think that keeping the associated HWND with the surface could
> be useful in the future, so that could possibly replace the
> dummy_surface flag. But as it's not useful immediately it may be
> changed later as well.

Yeah, I think storing HWND instead of a dedicated flag looks more
appropriate.




More information about the wine-devel mailing list