[PATCH] msi: Set first dialog as parent in subsequent dialogs

Chip Davis cdavis at codeweavers.com
Mon Aug 9 00:54:04 CDT 2021

August 8, 2021 5:12 PM, "Fabian Maurer" <dark.shadow4 at web.de> wrote:

> diff --git a/dlls/msi/dialog.c b/dlls/msi/dialog.c
> index 703f9d43957..144d7308b3f 100644
> --- a/dlls/msi/dialog.c
> +++ b/dlls/msi/dialog.c
> @@ -139,6 +139,7 @@ typedef struct
>  static DWORD uiThreadId;
>  static HWND hMsiHiddenWindow;
> +static HANDLE hPrevious = NULL;

This is a fairly minor issue, but I don't think using generic 'HANDLE' as the type instead of specific 'HWND' here is a good idea. Also, Hungarian notation is discouraged in Wine now. You don't have to change the other variables; just please don't use Hungarian on new variables that you add.


More information about the wine-devel mailing list