[PATCH v1] mmdevapi: Implement AEV_GetMasterVolumeLevelScalar and AEV_SetMasterVolumeLevelScalar methods.

Andrew Eikum aeikum at codeweavers.com
Mon Aug 9 09:55:38 CDT 2021


On Thu, Aug 05, 2021 at 01:34:49PM +0800, Jactry Zeng wrote:
> Hi,
> 
> On 8/5/21 1:24 PM, Haidong Yu wrote:
> >  
> > +static float g_master_vol = 1.f;
> > +
> Is it reasonable to store this in AEVImpl struct instead?
> 

It would also be good to add some tests for this. And please leave the
FIXME traces in there, since this patch does not actually implement
these methods.

Thanks,
Andrew



More information about the wine-devel mailing list