[PATCH 3/5] winebus.sys: Use a local variable to store buffer len.

Rémi Bernon rbernon at codeweavers.com
Thu Aug 12 14:55:39 CDT 2021

On 8/12/21 7:19 PM, Zebediah Figura (she/her) wrote:
> Looks fine to me, but maybe "output_len" would be better?

As the thing it's writing to is named "UserBuffer" I probably found that 
it was making sense. I don't really mind though.

> (Also strikes me as weird that "code" isn't initialized in the same 
> place. Also, maybe the patch subject could reflect that we're using 
> local variables for multiple ioctl parameters?)

Yeah, it was really long with the declaration on the same line, and the 
inline switch initialization looked nice.

I'll put them on two lines.
Rémi Bernon <rbernon at codeweavers.com>

More information about the wine-devel mailing list