[PATCH 1/7] winebus.sys: Read irp->IoStatus.Status before leaving the CS.

Rémi Bernon rbernon at codeweavers.com
Fri Aug 13 02:46:12 CDT 2021


Or we may have a race condition where a pending IRP may be completed
after we left the CS but before we read its status.

Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
---
 dlls/winebus.sys/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/winebus.sys/main.c b/dlls/winebus.sys/main.c
index 001f775e230..b7230cf2e33 100644
--- a/dlls/winebus.sys/main.c
+++ b/dlls/winebus.sys/main.c
@@ -982,9 +982,9 @@ static NTSTATUS WINAPI hid_internal_dispatch(DEVICE_OBJECT *device, IRP *irp)
             break;
     }
 
+    status = irp->IoStatus.Status;
     LeaveCriticalSection(&ext->cs);
 
-    status = irp->IoStatus.Status;
     if (status != STATUS_PENDING) IoCompleteRequest(irp, IO_NO_INCREMENT);
     return status;
 }
-- 
2.32.0




More information about the wine-devel mailing list