[PATCH] kernel32/tests: Don't skip the sorting tests on Windows.

Francois Gouget fgouget at codeweavers.com
Tue Aug 17 10:32:50 CDT 2021


Only skip them in Wine since it's missing a compatible collation table.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
As far as I can tell they do succeed on Windows so it's better to run 
them to make sure it remains that way.
---
 dlls/kernel32/tests/locale.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/dlls/kernel32/tests/locale.c b/dlls/kernel32/tests/locale.c
index a518aa15888..2bdb075590d 100644
--- a/dlls/kernel32/tests/locale.c
+++ b/dlls/kernel32/tests/locale.c
@@ -3054,6 +3054,13 @@ static void test_sorting(void)
 
     assert(sizeof(buf) >= sizeof(strings));
 
+    /* this requires the collation table patch to make it MS compatible */
+    if (strcmp(winetest_platform, "wine") == 0)
+    {
+        skip("in Wine due to the lack of a compatible collation table\n");
+        return;
+    }
+
     /* 1. sort using lstrcmpA */
     memcpy(buf, strings, sizeof(strings));
     qsort(buf, ARRAY_SIZE(strings), sizeof(strings[0]), compare_string1);
@@ -7144,6 +7151,5 @@ START_TEST(locale)
   test_SpecialCasing();
   test_NLSVersion();
   test_geo_name();
-  /* this requires collation table patch to make it MS compatible */
-  if (0) test_sorting();
+  test_sorting();
 }
-- 
2.20.1



More information about the wine-devel mailing list