[PATCH v4] user32: Don't save maximized position placement for toplevel windows covering the entire work area.

Gabriel Ivăncescu gabrielopcode at gmail.com
Wed Aug 25 08:18:09 CDT 2021


On 25/08/2021 10:21, Huw Davies wrote:
> On Tue, Aug 24, 2021 at 08:23:12PM +0300, Gabriel Ivăncescu wrote:
>> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51672
>> Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
>> ---
>>   dlls/user32/tests/win.c | 54 +++++++++++++++++++++++-------
>>   dlls/user32/winpos.c    | 73 +++++++++++++++++++++++++++++++++--------
>>   2 files changed, 102 insertions(+), 25 deletions(-)
>>
>> diff --git a/dlls/user32/winpos.c b/dlls/user32/winpos.c
>> index 6e96a4b..7edd63a 100644
>> --- a/dlls/user32/winpos.c
>> +++ b/dlls/user32/winpos.c
>> @@ -675,6 +675,27 @@ BOOL WINAPI MoveWindow( HWND hwnd, INT x, INT y, INT cx, INT cy,
>>   }
>>   
>>   
>> +/*******************************************************************
>> + *           get_maximized_area_rect
>> + *
>> + * Get the work area that a maximized window can cover, depending on style.
>> + */
>> +static RECT get_work_rect_for_style( HMONITOR monitor, DWORD style )
> 
> Why not move the call to MonitorFromWindow() into this function since both
> callers don't use monitor elsewhere?
> 
> Huw.
> 

But GetMinMaxInfo checks for failure there and does other things on top 
of that, how should I check for it then?



More information about the wine-devel mailing list