[PATCH 1/4] wininet/tests: Update InternetErrorDlg tests taking recent Windows 10 results as a base.
Jacek Caban
jacek at codeweavers.com
Thu Aug 26 10:37:55 CDT 2021
Hi Dmitry,
On 8/6/21 2:43 PM, Dmitry Timoshkov wrote:
> @@ -1583,7 +1586,7 @@ static void test_InternetErrorDlg(void)
> expected = ERROR_INVALID_PARAMETER;
>
> res = InternetErrorDlg(hwnd, NULL, i, FLAGS_ERROR_UI_FLAGS_NO_UI, NULL);
> - todo_wine_if( test_flags & FLAG_TODO || i == ERROR_INTERNET_INCORRECT_PASSWORD)
> + todo_wine_if ((test_flags & FLAG_TODO) || i == ERROR_INTERNET_INCORRECT_PASSWORD || i == ERROR_INTERNET_INSERT_CDROM || i == ERROR_INTERNET_CLIENT_AUTH_CERT_NEEDED)
Is there a reason why you don't use FLAG_TODO for those? It may not
match what you need for your new tests, but why are you changing half of
its usage here?
Thanks,
Jacek
More information about the wine-devel
mailing list