[PATCH] comctl32: Fix ASCII / ANSI mixups in comments.

Nikolay Sivov nsivov at codeweavers.com
Fri Aug 27 08:30:58 CDT 2021


On 8/27/21 4:18 PM, Francois Gouget wrote:
> On Fri, 27 Aug 2021, Nikolay Sivov wrote:
>
>>
>> On 8/27/21 1:37 PM, Francois Gouget wrote:
>>> Signed-off-by: Francois Gouget <fgouget at free.fr>
>>> ---
>>>  dlls/comctl32/listview.c | 2 +-
>>>  dlls/comctl32/toolbar.c  | 2 +-
>>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c
>>> index 8cbfee834ce..88b42db4c41 100644
>>> --- a/dlls/comctl32/listview.c
>>> +++ b/dlls/comctl32/listview.c
>>> @@ -6101,7 +6101,7 @@ static HWND CreateEditLabelT(LISTVIEW_INFO *infoPtr, LPCWSTR text, BOOL isW)
>>>   * PARAMETER(S):
>>>   * [I] infoPtr : valid pointer to the listview structure
>>>   * [I] nItem : item index
>>> - * [I] isW : TRUE if it's a Unicode req, FALSE if ASCII
>>> + * [I] isW : TRUE if it's a Unicode req, FALSE if ANSI
>>>   *
>>>   * RETURN:
>>>   *   SUCCESS : TRUE
>> I'd rather remove this whole header.
> You mean the function documentation?
>
> It does not feel right to remove just this one and not the 143 others. 
> And I don't feel like blindly removing all of them (or figuring out 
> which ones to remove and which ones to keep).
The only thing this kind of description does is getting outdated over
time and contradicting function itself. That's the case for this helper,
that's why I commented at all. But you're right, there is more than one.



More information about the wine-devel mailing list