[PATCH 4/6] winebus.sys: Stop enforcing input and IG suffix on gamepads.

Rémi Bernon rbernon at codeweavers.com
Fri Aug 27 14:14:09 CDT 2021


On 8/27/21 7:59 PM, Zebediah Figura (she/her) wrote:
> On 8/26/21 12:59 AM, Rémi Bernon wrote:
>> The &IG_00 suffix is now automatically added by xinput.sys.
>>
>> Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
>> ---
>>   dlls/winebus.sys/bus_iohid.c |  5 +----
>>   dlls/winebus.sys/bus_sdl.c   |  5 +----
>>   dlls/winebus.sys/bus_udev.c  |  2 --
>>   dlls/winebus.sys/main.c      | 18 ++++--------------
>>   4 files changed, 6 insertions(+), 24 deletions(-)
>>
> 
> Don't we still want to add the MI suffix where applicable?
> 

I'm not sure what you mean by "where applicable"? When we can and do 
detect an input number (although it's actually pretty bogus), we add the 
&MI_ suffix.

I understand it's used for composite devices with multiple interfaces, 
but UDEV bus devices for instance may get an "input" number parsed from 
uevent even if they aren't composite.

In any case I'm not completely sure how useful it is anyway.
-- 
Rémi Bernon <rbernon at codeweavers.com>



More information about the wine-devel mailing list