[PATCH] ntdll: Truncate and ellipsize debug output if it's too long.

Alexandre Julliard julliard at winehq.org
Fri Aug 27 14:29:47 CDT 2021

"Esme Povirk (she/they)" <esme at codeweavers.com> writes:

> Is there anything I can do to help move this along?
> append_output only interacts with one other function, and this doesn't
> change the interface to it, so from a correctness perspective, I think
> this should be easy to verify.

It doesn't look quite correct, you'd need to flush the buffer otherwise
you'll potentially lose even more output.

> From a design perspective, I don't know if this is right, but I
> couldn't think of a better approach. Exposing the buffer size to
> callers seems not ideal to me. Is there an alternative I'm missing?

I'd suggest using debugstr_a/w like everywhere else. If you have to
print an unbounded number of arguments, you can print them one per line.

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list