[PATCH] advapi32/tests: The preferred UI language check must be case insensitive.

Francois Gouget fgouget at codeweavers.com
Mon Dec 6 04:19:38 CST 2021


On Mon, 6 Dec 2021, Francois Gouget wrote:

> This avoid skipping the test for the French locale.
> 
> Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
> ---
> It looks like langW was in lowercase back when w10pro64 was running 
> Windows 10 2004; but it's uppercase in 21H1 which is why the 
> advapi32:lsa failure disappeared for the French locale.

I confused two issues:
* "Everyone" was not translated when w10pro64 was running Windows 10 
  2004 which caused the test to fail. This proves that langW was all 
  uppercase then too.

* And it's only in Wine that langW is lowercase. Windows 7, Windows 10 
  2004 and 21H1 all put it in uppercase. So the right fix is probably to 
  modify Wine so GetSystemPreferredUILanguages() returns an uppercase 
  string.

So I think it's best to ignore this patch.


-- 
Francois Gouget <fgouget at codeweavers.com>



More information about the wine-devel mailing list