[PATCH 04/18] programs/winedbg: introduce dbg_lg(u)int_t and migrate all integral computations on this type

Alexandre Julliard julliard at winehq.org
Mon Dec 6 05:18:13 CST 2021


Eric Pouech <eric.pouech at gmail.com> writes:

> diff --git a/programs/winedbg/debugger.h b/programs/winedbg/debugger.h
> index 1d3156bf8a3..8c909361a58 100644
> --- a/programs/winedbg/debugger.h
> +++ b/programs/winedbg/debugger.h
> @@ -65,6 +65,13 @@ enum dbg_line_status
>      dbg_in_a_thunk,
>  };
>  
> +/* in all cases (PE32, PE64) for the debugger,
> + * the following integral types have fixed width (in bits):
> + *   char = 8, short = 16, int = 32, long = 64, long long = 128
> + * the following float types have fixed width (in bytes):
> + *   short real = 4, real = 8, long real = 10
> + * Note that PE compiler doesn't support (today) 128 bit integers nor 10 byte reals.

That's very confusing. If the types are not going to match the compiler
I'd suggest renaming them to int16, int32, int64 etc.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list