[PATCH 1/2] include: Add namespaceapi.h file.

Mohamad Al-Jaf mohamadaljaf at gmail.com
Tue Dec 7 01:44:19 CST 2021


Thank you for the help and feedback. I have submitted a revision. :)

On Tue, Dec 7, 2021 at 1:20 AM Jactry Zeng <jzeng at codeweavers.com> wrote:

> On 12/7/21 04:42, Mohamad Al-Jaf wrote:
> > I'm not sure on which line to add it to, is it okay to add it on line
> 3750,
> > before #define SID_REVISION?
>
> This looks fine to me.
>
> >
> > How come they used the value 0x1? It's 0x01 on the Microsoft Docs site.
> As
> > far as I know, they are the same value but differ in bit value and the
> > compiler evaluates them to the same value. So for copyright purposes,
> would
> > it be better to add or remove extra 0s? Should I do the same
> > for PRIVATE_NAMESPACE_FLAG_DESTROY?
>
> I don't see this really matters, I think you can just choose the one
> you'd prefer.
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20211207/1ad2079b/attachment.htm>


More information about the wine-devel mailing list