[PATCH 6/6] win32u: Use user driver for wine_get_vulkan_driver.

[Jacek Caban]

On 12/7/21 10:11 PM, Alexandre Julliard wrote:
> Huw Davies <huw at codeweavers.com> writes:
>
>> On Tue, Dec 07, 2021 at 10:01:12AM -0600, Marvin wrote:
>>> Hi,
>>>
>>> While running your changed tests, I think I found new failures.
>>> Being a bot and all I'm not very good at pattern recognition, so I might be
>>> wrong, but could you please double-check?
>>>
>>> Full results can be found at:
>>> https://testbot.winehq.org/JobDetails.pl?Key=103547
>>>
>>> Your paranoid android.
>>>
>>>
>>> === debiant2 (32 bit Chinese:China report) ===
>>>
>>> dxgi:
>>> dxgi.c:2614: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768).
>>> dxgi.c:2618: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768).
>>> dxgi.c:2687: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768).
>>> dxgi.c:2694: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768).
>>> dxgi.c:2687: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768).
>>> dxgi.c:2694: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768).
>>> dxgi.c:2709: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768).
>>> dxgi.c:2874: Test failed: Got monitor rect (0,0)-(800,600), expected (0,0)-(1024,768).
>>>
>> These look new, right?
> They happen occasionally, so it's not caused by this specific patch. It
> may be caused by the win32u changes in general though, possibly because
> of timings differences. At least I don't remember seeing these before
> the win32u migration started.


I don't see this one, but I've seen similar problem of synchronization 
between caches before I moved monitor cache to win32u. It seemed to me 
that depending on registry write time resolution is not good enough. If 
that's right, then it's not really new, except that the new code 
requires fewer server calls, so may be more likely to hit the problem. 
Something like the attached patch could help in this case, but in theory 
it's similar between different processes.


Thanks,

Jacek

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-patch
Size: 1076 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20211207/044125e3/attachment.bin>