[PATCH 1/2] comctl32/tests: Fix a test failure on Win10 21H1 with Hebrew locale.

Francois Gouget fgouget at codeweavers.com
Fri Dec 10 05:31:39 CST 2021


On Thu, 9 Dec 2021, Zhiyi Zhang wrote:
[...]
> >> comctl32:
> >> propsheet.c:821: Test failed: property sheet with custom window proc: the msg 0x001c was expected, but got msg 0x0047 instead
> > This is an unrelated preexisting but random failure.
> > So I think it should not prevent the patch from being applied.
> 
> The random message failure was fixed by 3c789e2, which was the 2/2 
> patch of this series.

Yes. That helped a lot. There was still a failure happening regularly on 
the cw-gtx560 machine in the Windows 10 1709 and 1809 cases (got 0x0046 
nistead of 0x0210) but I figured out it was because Windows was asking 
at boot about whether the machine should be discoverable on the network. 
That sidebar dialog caused the message ordering issues. So I dismissed 
the dialog and redid the snapshots and these failures are gone.

The same failure happened once after the patch on fgtb-w10pro64-rx550 
but I'll assume this was caused by some previous test crashing / leaving 
a dialog up. It has not happened again so I think comctl32:propsheet 
will be all clean once the Hebrew situation is resolved.

Hence my interest in getting this patch or some variant committed :-)


-- 
Francois Gouget <fgouget at codeweavers.com>



More information about the wine-devel mailing list