testbot final screenshot (Re: [PATCH] comdlg32: Avoid crash in RemoveControlItem.)

[Francois Gouget]

On Fri, 10 Dec 2021, Bernhard Übelacker wrote:

> Am 10.12.21 um 13:09 schrieb Marvin:
> 
> > === w7u_2qxl (32 bit report) ===
> > 
> > comdlg32:
> > itemdlg: Timeout
> > 
> ...
> > === w1064v1507 (32 bit report) ===
> > 
> > comdlg32:
> > itemdlg: Timeout
> > 
> ...
> 
> 
> Hello Francois,
> I tried to submit today this patch, unfortunately it timed out at
> each Windows 7 and 10 VMs.
> 
> It times out also with a patch that should not change behaviour
> when manually submitting.
> E.g. https://testbot.winehq.org/GetFile.pl?JobKey=103828

You should be able to diagnose that by checking:

  Timestamp traces (WINETEST_TIME)
and/or
  Report successful tests (WINETEST_REPORT_SUCCESS)


> I assume in my case winetest detects the runtime of more than 120
> seconds, terminates the child process and ends itself,
> then the screenshot is taken?

Usually yes. Technically there's a bit of a race between the timeout in 
Winetest.exe and the process monitoring the task on the TestBot server. 
But normally Winetest.exe is supposed to time out first.

It looks like the 'stack trace' of the test getting stuck is something 
like this:

itemdlg.c:1530:9.359 Test succeeded  // test_filename()
itemdlg.c:102:9.406 Test succeeded   // get_hwnd_from_ifiledialog()
itemdlg.c:221:9.422 Test succeeded   // IFileDialogEvents_fnOnFolderChange()

https://testbot.winehq.org/JobDetails.pl?Key=103851

It may be necessary to add some more traces to pinpoint exactly where 
the test gets stuck.


> Is there a way to get the screenshot before the timeout of winetest.exe is
> reached? E.g. a possibility to reduce some kind of "outer" timeout?

There's a plan to take screenshots at a to-be-determined regular 
interval. Some progress has been made on it but there's a dozen other 
things to improve on the TestBot and at some point it fell by the 
wayside :-(

https://bugs.winehq.org/show_bug.cgi?id=44709

-- 
Francois Gouget <fgouget at codeweavers.com>