[PATCH v2 1/5] winevulkan: Support prefixing function parameters.

[Jacek Caban]

On 12/10/21 2:52 PM, Rémi Bernon wrote:
> On 12/10/21 14:21, Jacek Caban wrote:
>> On 12/10/21 10:26 AM, Rémi Bernon wrote:
>>> On 12/10/21 03:07, Jacek Caban wrote:
>>>>
>>>> To allow them being accessed from a struct.
>>>>
>>>> Signed-off-by: Jacek Caban <jacek at codeweavers.com>
>>>> ---
>>>> v2: make remaining direct calls more similar to __wine_unix_call
>>>>
>>>>   dlls/winevulkan/make_vulkan | 59 
>>>> ++++++++++++++++++++-----------------
>>>>   1 file changed, 32 insertions(+), 27 deletions(-)
>>>>
>>>>
>>>
>>> Thanks, it indeed fixes the issue with Control DX12.
>>>
>>> Now that it works I could measure that the series causes a ~25% fps 
>>> drop in that same game, from an average of 165fps to 125fps measured 
>>> with WINEDEBUG=+fps, while being steady near the beginning of the game. 
>>
>>
>> That's interesting, it's worse than what I've seen in cases that 
>> seemed to be pretty bad examples wrt. an impact of those patches. I 
>> will look at it myself as well, but for comparison, could you please 
>> try the attached patch on top of the series? If it's similar to what 
>> I've seen so far, that should mitigate the problem.
>>
>
> Hi Jacek, sorry but the patch doesn't help.


I repeated your tests and for me, the attached patch is enough to make 
performance difference marginal. It adds direct calls for 
vkUpdateDescriptorSets compared to previous patch.


Thanks,

Jacek

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-patch
Size: 901 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20211210/7b82e820/attachment.bin>