[PATCH v3 6/8] jscript: Return the correct string for Object.toString(null) in ES5+ modes.

Gabriel Ivăncescu gabrielopcode at gmail.com
Fri Dec 10 15:43:56 CST 2021


On 10/12/2021 22:16, Jacek Caban wrote:
> On 12/7/21 8:10 PM, Gabriel Ivăncescu wrote:
>> Signed-off-by: Gabriel Ivăncescu<gabrielopcode at gmail.com>
>> ---
>>
>> I kept the check in Object_toString, because that's what the spec says 
>> and
>> special cases before calling to_object, and it's changed from version ES3
>> to ES5.
> 
> 
> If 'this' is always an object in ES3, then how is it possible to reach 
> this this condition? There is similar case in Error.toString in patch 4.
> 
> 

Sorry, I had to go out. Oh, I didn't think of it, but now it makes sense 
since both apply & call do that. I'm guessing it might be too late for 
code freeze now, but I'll resend anyways.



More information about the wine-devel mailing list