testbot final screenshot (Re: [PATCH] comdlg32: Avoid crash in RemoveControlItem.)

[Francois Gouget]

On Sat, 11 Dec 2021, Bernhard Übelacker wrote:
[...]
> This hang with this "File not found" message
> seems to be caused by the test started with current directory in
> public documents, where also the test files get generated.

While most of the TestBot VMs start the tests in public documents, they 
may start them in other places. One VM started them from e:\ (though 
that may have been a Vista VM so moot now).

In any case the tests cannot make assumptions on what the current 
directory will be. So if comdlg32:itemdlg needs to be run in the user's 
Documents directory, then it should chdir there, no matter what the 
initial directory was.


> Therefore cannot find them in my documents.

I did not go through the test code in detail so I may ask a stupid 
question. But why does the dialog look for the files in the user's 
documents folder?

Is it because the dialog is opened with an option that says to show the 
content of the user's documents folder?

If so then maybe the test files should be created there and then 
changing the current directory would not even be needed.

Or maybe the dialog could be told to open the current directory instead, 
though that may be less reliable (e.g. is cwd == c:\ )

-- 
Francois Gouget <fgouget at codeweavers.com>