[PATCH] kernel32/tests: Split up checks in flush_proc function

Alex Henrie alexhenrie24 at gmail.com
Sun Dec 12 20:04:29 CST 2021


This test is failing intermittently on the testbot but not enough
information is output to tell why.

Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
---
 dlls/kernel32/tests/pipe.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/dlls/kernel32/tests/pipe.c b/dlls/kernel32/tests/pipe.c
index 93eeca16c75..5af92f8f8a5 100644
--- a/dlls/kernel32/tests/pipe.c
+++ b/dlls/kernel32/tests/pipe.c
@@ -2858,9 +2858,15 @@ static DWORD CALLBACK flush_proc(HANDLE pipe)
 
     res = FlushFileBuffers(pipe);
     if (expected_flush_error == ERROR_SUCCESS)
+    {
         ok(res, "FlushFileBuffers failed: %u\n", GetLastError());
+    }
     else
-        ok(!res && GetLastError() == expected_flush_error, "FlushFileBuffers failed: %u\n", GetLastError());
+    {
+        ok(!res, "FlushFileBuffers should have failed\n");
+        ok(GetLastError() == expected_flush_error,
+           "FlushFileBuffers set error %u, expected %u\n", GetLastError(), expected_flush_error);
+    }
     return 0;
 }
 
-- 
2.34.1




More information about the wine-devel mailing list