[PATCH v5 2/5] jscript: Pass null jsval to builtin functions instead of the global host.

Jacek Caban jacek at codeweavers.com
Mon Dec 13 15:12:59 CST 2021


Hi Gabriel,

The series will obviously need to wait for the code freeze. I took a 
look and didn't catch problems with patch 1 (although I will have 
another look when the time comes).

On 12/10/21 10:52 PM, Gabriel Ivăncescu wrote:
>       else
> -        vthis = jsval_disp(lookup_global_host(ctx));
> +        vthis = jsval_null();


This looks suspicious, doesn't it break the assumption that 'this' is an 
object in ES3?


Thanks,

Jacek




More information about the wine-devel mailing list