[PATCH v2] darwin: Fix non-Metal build

[Dean Greer]

I’d said the patch is invalid as it didn’t work when I’ve attempted to
compile wine with it applied. I could only get it to compile when using the
MacOSX10.11.SDK without disabling Metal but that’s unfortunately worthless
as Macports rev-upgrade will report the build as broken due to
metal.framework being linked.

Last I checked Macports didn’t ignore weak linked libraries/frameworks so
weak linking isn’t an option unfortunately.

I’ve not ran any regression tests yet but did narrow it down to wine-6.17
being when winemac.drv first broke that’s when Chip did some changes so
possibly that series of patches cause this breakage.

On Wed, Dec 15, 2021 at 8:17 PM Keno Fischer <keno at juliacomputing.com>
wrote:

> Hi Dean,
>
> sorry, I missed your follow up messages to this.
>
> > Even with this patch wine-7.0-rc1 without Metal fails to compile
>
> Hmm, that's odd. The error you're seeing is precisely the one I was
> attempting to address with this patch. As you can see in [1], we did
> successfully build wine for Darwin with this patch.
>
> > As this framework was never linked prior outside of a Metal build this
> > patch is invalid
>
> Ok, I don't know the history here. Getting rid of QuartzCore in the
> non-Metal build would of course address the issue as well.
> I'll drop this patch then and wait for a proper fix.
>
> [1]
> https://dev.azure.com/JuliaPackaging/Yggdrasil/_build/results?buildId=15191&view=logs&jobId=aaafd674-36c9-520f-061a-210bf173b325&j=aaafd674-36c9-520f-061a-210bf173b325&t=d2ed9532-d9b7-51c7-b4a9-ce32623b9b7c
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20211215/908f1c80/attachment.htm>